A federal appeals court has upheld the conviction of a man who went on a failed search for buried treasure at Yellowstone National Park and had to be rescued by helicopter.